From commits-return-13103-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Mar 10 19:34:26 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DC4B218064E for ; Tue, 10 Mar 2020 20:34:25 +0100 (CET) Received: (qmail 72387 invoked by uid 500); 10 Mar 2020 19:34:25 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 72378 invoked by uid 99); 10 Mar 2020 19:34:25 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Mar 2020 19:34:25 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1073: [HUDI-377] Adding Delete() support to DeltaStreamer Message-ID: <158386886515.1167.9116994673416571179.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 10 Mar 2020 19:34:25 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit prashantwason commented on a change in pull request #1073: [HUDI-377] Adding Delete() support to DeltaStreamer URL: https://github.com/apache/incubator-hudi/pull/1073#discussion_r390562273 ########## File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java ########## @@ -394,8 +394,8 @@ private void testUpsertsContinuousMode(HoodieTableType tableType, String tempDir } else { TestHelpers.assertAtleastNCompactionCommits(5, datasetBasePath, dfs); } - TestHelpers.assertRecordCount(totalRecords, datasetBasePath + "/*/*.parquet", sqlContext); - TestHelpers.assertDistanceCount(totalRecords, datasetBasePath + "/*/*.parquet", sqlContext); + TestHelpers.assertRecordCount(totalRecords + 200, datasetBasePath + "/*/*.parquet", sqlContext); Review comment: Thanks Sivabalan for such a quick reply. I had filed https://issues.apache.org/jira/browse/HUDI-667 to work on this fix. You may wish to use it to submit your PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services