From commits-return-12922-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Mon Mar 9 06:19:39 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B66DE180181 for ; Mon, 9 Mar 2020 07:19:38 +0100 (CET) Received: (qmail 71423 invoked by uid 500); 9 Mar 2020 06:19:38 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 71414 invoked by uid 99); 9 Mar 2020 06:19:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Mar 2020 06:19:38 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1388: [HUDI-681]Remove embeddedTimelineService from HoodieReadClient Message-ID: <158373477799.10697.12291706892811855401.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 09 Mar 2020 06:19:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vinothchandar commented on a change in pull request #1388: [HUDI-681]Remove embeddedTimelineService from HoodieReadClient URL: https://github.com/apache/incubator-hudi/pull/1388#discussion_r389478969 ########## File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java ########## @@ -100,14 +91,6 @@ public HoodieReadClient(JavaSparkContext jsc, String basePath, SQLContext sqlCon * @param clientConfig instance of HoodieWriteConfig */ public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig) { - this(jsc, clientConfig, Option.empty()); - } - - /** - * @param clientConfig instance of HoodieWriteConfig - */ - public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig, - Option timelineService) { Review comment: so this was not doing anything after we changed the class hierrarchy? and this PR is cleaning this up? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services