From commits-return-12845-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Sat Mar 7 22:15:21 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 83DCB18025F for ; Sat, 7 Mar 2020 23:15:21 +0100 (CET) Received: (qmail 16199 invoked by uid 500); 7 Mar 2020 22:15:21 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 16187 invoked by uid 99); 7 Mar 2020 22:15:20 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2020 22:15:20 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] smarthi commented on a change in pull request #1380: [HUDI-668] Added unit-tests for HUDI metrics. Message-ID: <158361932081.18824.16219942063542551631.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 07 Mar 2020 22:15:20 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit smarthi commented on a change in pull request #1380: [HUDI-668] Added unit-tests for HUDI metrics. URL: https://github.com/apache/incubator-hudi/pull/1380#discussion_r389316113 ########## File path: hudi-client/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java ########## @@ -18,29 +18,144 @@ package org.apache.hudi.metrics; +import org.apache.hudi.common.model.HoodieCommitMetadata; import org.apache.hudi.config.HoodieWriteConfig; import org.junit.Before; import org.junit.Test; +import com.codahale.metrics.Timer; + import static org.apache.hudi.metrics.Metrics.registerGauge; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; import static org.mockito.Mockito.mock; import static org.mockito.Mockito.when; +import java.util.Arrays; +import java.util.Random; + Review comment: Move the static imports after other imports at the end ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services