From commits-return-12368-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Sun Mar 1 10:46:42 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2967F18064F for ; Sun, 1 Mar 2020 11:46:42 +0100 (CET) Received: (qmail 29856 invoked by uid 500); 1 Mar 2020 10:46:41 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 29846 invoked by uid 99); 1 Mar 2020 10:46:41 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 01 Mar 2020 10:46:41 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] codecov-io edited a comment on issue #1106: [HUDI-209] Implement JMX metrics reporter Message-ID: <158305960108.25489.17533836341489447044.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sun, 01 Mar 2020 10:46:41 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io edited a comment on issue #1106: [HUDI-209] Implement JMX metrics reporter URL: https://github.com/apache/incubator-hudi/pull/1106#issuecomment-593074963 # [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=h1) Report > Merging [#1106](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-hudi/commit/0dc8e493aa1658910a3519df3941278d9d072c18?src=pr&el=desc) will **decrease** coverage by `0.3%`. > The diff coverage is `5.21%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-hudi/pull/1106/graphs/tree.svg?width=650&token=VTTXabwbs2&height=150&src=pr)](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #1106 +/- ## ============================================ - Coverage 67.08% 66.77% -0.31% Complexity 223 223 ============================================ Files 333 334 +1 Lines 16207 16291 +84 Branches 1657 1662 +5 ============================================ + Hits 10873 10879 +6 - Misses 4598 4676 +78 Partials 736 736 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [.../java/org/apache/hudi/metrics/MetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXIuamF2YQ==) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/hudi/metrics/MetricsReporterFactory.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzUmVwb3J0ZXJGYWN0b3J5LmphdmE=) | `46.15% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...va/org/apache/hudi/metrics/MetricsJmxReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzSm14UmVwb3J0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...g/apache/hudi/metrics/MetricsGraphiteReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzR3JhcGhpdGVSZXBvcnRlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...java/org/apache/hudi/config/HoodieWriteConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZVdyaXRlQ29uZmlnLmphdmE=) | `83.84% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...ava/org/apache/hudi/metrics/JmxReporterServer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9KbXhSZXBvcnRlclNlcnZlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...g/apache/hudi/metrics/InMemoryMetricsReporter.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9Jbk1lbW9yeU1ldHJpY3NSZXBvcnRlci5qYXZh) | `100% <100%> (+25%)` | `0 <0> (ø)` | :arrow_down: | | [...va/org/apache/hudi/config/HoodieMetricsConfig.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvY29uZmlnL0hvb2RpZU1ldHJpY3NDb25maWcuamF2YQ==) | `59.37% <100%> (+4.53%)` | `0 <0> (ø)` | :arrow_down: | | [...src/main/java/org/apache/hudi/metrics/Metrics.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvbWV0cmljcy9NZXRyaWNzLmphdmE=) | `70.27% <100%> (+1.69%)` | `0 <0> (ø)` | :arrow_down: | | [...i/utilities/deltastreamer/HoodieDeltaStreamer.java](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree#diff-aHVkaS11dGlsaXRpZXMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2h1ZGkvdXRpbGl0aWVzL2RlbHRhc3RyZWFtZXIvSG9vZGllRGVsdGFTdHJlYW1lci5qYXZh) | `79.79% <0%> (-1.02%)` | `8% <0%> (ø)` | | | ... and [5 more](https://codecov.io/gh/apache/incubator-hudi/pull/1106/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=footer). Last update [0dc8e49...c75c640](https://codecov.io/gh/apache/incubator-hudi/pull/1106?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services