hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] satishkotha opened a new pull request #1392: [HUDI-689] Change CLI command names to not have overlap
Date Tue, 10 Mar 2020 17:30:43 GMT
satishkotha opened a new pull request #1392: [HUDI-689] Change CLI command names to not have
overlap
URL: https://github.com/apache/incubator-hudi/pull/1392
 
 
   ## What is the purpose of the pull request
   I broke CLI when i added compactions show archived command.
    I still dont understand spring shell well enough to explain why the existing commands
wont work. But the alternative commands I picked seemed to work. Please let me know if any
of you have seen similar issues with spring shell and how command parsing works.
   
   CLI 'commits show archived' fails with
   
   ->commits show archived
   Option '' is not available for this command. Use tab assist or the "help" command to see
the legal options
   This seems to be because 'compactions show archived'. If i remove @CliCommand annotation
from compactions, commits show archived works.
   
   ## Brief change log
   
   - Chose different command names to make all commands 'work'
   - change method names to not overlap with each other
   
   
   ## Verify this pull request
   
   Manually verified the change by running CLI
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message