hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] smarthi commented on a change in pull request #1159: [HUDI-479] Eliminate or Minimize use of Guava if possible
Date Thu, 26 Mar 2020 05:59:06 GMT
smarthi commented on a change in pull request #1159: [HUDI-479] Eliminate or Minimize use of
Guava if possible
URL: https://github.com/apache/incubator-hudi/pull/1159#discussion_r398333676
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/ReflectionUtils.java
 ##########
 @@ -90,16 +99,58 @@ public static Object loadClass(String clazz, Object... constructorArgs)
{
   }
 
   /**
-   * Return stream of top level class names in the same class path as passed-in class.
-   * 
-   * @param clazz
+   * Scans all classes accessible from the context class loader
+   * which belong to the given package and subpackages.
+   *
+   * @param clazz class
+   * @return Stream of Class names in package
    */
-  public static Stream<String> getTopLevelClassesInClasspath(Class clazz) {
+  public static Stream<String> getTopLevelClassesInClasspath(Class<?> clazz)
{
 
 Review comment:
   yes - let's raise a jira

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message