hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic
Date Wed, 25 Mar 2020 03:47:22 GMT
xushiyan commented on a change in pull request #1436: [HUDI-711] Refactor exporter main logic
URL: https://github.com/apache/incubator-hudi/pull/1436#discussion_r397592137
 
 

 ##########
 File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieSnapshotExporter.java
 ##########
 @@ -159,18 +161,85 @@ public void testExportAsHudi() throws IOException {
       assertTrue(dfs.exists(new Path(partition + "/.hoodie_partition_metadata")));
       assertTrue(dfs.exists(new Path(targetPath + "/_SUCCESS")));
     }
+  }
+
+  public static class TestHoodieSnapshotExporterForEarlyAbort extends ExporterTestHarness
{
+
+    private HoodieSnapshotExporter.Config cfg;
+
+    @Before
+    public void setUp() throws Exception {
+      super.setUp();
+      cfg = new Config();
+      cfg.sourceBasePath = sourcePath;
+      cfg.targetOutputPath = targetPath;
+      cfg.outputFormat = OutputFormatValidator.HUDI;
+    }
 
     @Test
-    public void testExportEmptyDataset() throws IOException {
+    public void testExportWhenTargetPathExists() throws IOException {
+      // make target output path present
+      dfs.mkdirs(new Path(targetPath));
+
+      // export
+      Throwable t = null;
+      try {
+        new HoodieSnapshotExporter().export(jsc, cfg);
+      } catch (Exception e) {
+        t = e;
+      } finally {
+        assertNotNull(t);
+        assertTrue(t instanceof HoodieSnapshotExporterException);
+        assertEquals("The target output path already exists.", t.getMessage());
 
 Review comment:
   let me change these cases to using `ExpectedException`; something to do with
   
   ```java
   @Rule
   public ExpectedException exceptionRule = ExpectedException.none();
   ```
   
   I'll do a small commit and please see if it looks better. I kinda miss junit 5 😂 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message