hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] yanghua commented on issue #1440: [HUDI-731] Add ChainedTransformer
Date Tue, 24 Mar 2020 06:36:22 GMT
yanghua commented on issue #1440: [HUDI-731] Add ChainedTransformer
URL: https://github.com/apache/incubator-hudi/pull/1440#issuecomment-603045516
 
 
    @xushiyan 's explanation is correct. It's just about trade-off. Both of them can achieve
the same function, but the mechanism of collecting `Transformer` is different. Considering
that we have limited the functionality of this `Transformer` to: `ChainedTransformer`. Maybe
we can hide the "collect/assemble" logic to users? From this perspective, perhaps @vinothchandar
's suggestion is a little better for users. 
   
   After all, in terms of flexibility, if users want more flexibility, they can even directly
inherit the `Transformer` interface and implement everything you currently implement, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message