hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1150: [HUDI-288]: Add support for ingesting multiple kafka streams in a single DeltaStreamer deployment
Date Sun, 22 Mar 2020 20:17:09 GMT
bvaradar commented on a change in pull request #1150: [HUDI-288]: Add support for ingesting
multiple kafka streams in a single DeltaStreamer deployment
URL: https://github.com/apache/incubator-hudi/pull/1150#discussion_r396126493
 
 

 ##########
 File path: hudi-hive-sync/src/test/java/org/apache/hudi/hive/util/HiveTestService.java
 ##########
 @@ -121,6 +121,20 @@ public HiveServer2 start() throws IOException {
     return hiveServer;
   }
 
+  public void stop() {
 
 Review comment:
   Thanks for fixing this. Can you make TestUtil.stop() call this method to prevent leaks.
Also, check for other places to see this method needs to be called.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message