hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments to hudi write method link
Date Sun, 22 Mar 2020 05:02:57 GMT
wangxianghu commented on a change in pull request #1409: [HUDI-714]Add javadoc and comments
to hudi write method link
URL: https://github.com/apache/incubator-hudi/pull/1409#discussion_r396046670
 
 

 ##########
 File path: hudi-integ-test/src/test/java/org/apache/hudi/integ/ITTestHoodieDemo.java
 ##########
 @@ -110,9 +110,9 @@ private void setupDemo() throws Exception {
     executeCommandStringsInDocker(PRESTO_COORDINATOR, cmds);
 
     // copy presto sql files to presto coordinator
-    executePrestoCopyCommand( System.getProperty("user.dir") + "/.." + PRESTO_INPUT_TABLE_CHECK_RELATIVE_PATH,
HDFS_DATA_DIR);
-    executePrestoCopyCommand( System.getProperty("user.dir") + "/.." + PRESTO_INPUT_BATCH1_RELATIVE_PATH,
HDFS_DATA_DIR);
-    executePrestoCopyCommand( System.getProperty("user.dir") + "/.." + PRESTO_INPUT_BATCH2_RELATIVE_PATH,
HDFS_DATA_DIR);
+    executePrestoCopyCommand(System.getProperty("user.dir") + "/.." + PRESTO_INPUT_TABLE_CHECK_RELATIVE_PATH,
HDFS_DATA_DIR);
 
 Review comment:
   Not really, it is still the checkstyle from incubator-hudi/style/checkstyle.xml. When I
finish adding the doc and comments,I am not sure whether the changes I made meet up the checkstyle
requirements, so I scanned the entire project using the checkstyle plugin and found these
checkstyle issues, so I 'corrected' them . Are theses changes in checkstyle right? should
i revert them?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message