hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
Date Sat, 21 Mar 2020 05:16:25 GMT
vinothchandar commented on a change in pull request #1431: [HUDI-65]commitTime rename to instantTime
URL: https://github.com/apache/incubator-hudi/pull/1431#discussion_r395962699
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/common/HoodieTestDataGenerator.java
 ##########
 @@ -426,12 +426,12 @@ public HoodieRecord generateUpdateRecord(HoodieKey key, String commitTime)
throw
   /**
    * Generates deduped updates of keys previously inserted, randomly distributed across the
keys above.
    *
-   * @param commitTime Commit Timestamp
+   * @param instantTime Commit Timestamp
 
 Review comment:
   here too.. can you make a second pass everywhere

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message