hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for partitions
Date Fri, 20 Mar 2020 04:16:58 GMT
ffcchi commented on a change in pull request #1421: [HUDI-724] Parallelize getSmallFiles for
partitions
URL: https://github.com/apache/incubator-hudi/pull/1421#discussion_r395432973
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/table/HoodieMergeOnReadTable.java
 ##########
 @@ -374,16 +374,12 @@ public void finalizeWrite(JavaSparkContext jsc, String instantTs, List<HoodieWri
             sf.location = new HoodieRecordLocation(FSUtils.getCommitTime(filename), FSUtils.getFileId(filename));
             sf.sizeBytes = getTotalFileSize(smallFileSlice);
             smallFileLocations.add(sf);
-            // Update the global small files list
-            smallFiles.add(sf);
 
 Review comment:
   the UpsertPartitioner actually holds a global list small files for all partitions. since
the work will be distributed to Task nodes, the method can't  the small file to global list
anymore. So I moved the logic of updating that global list out side of the parallelism section.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message