hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver for DDL statements for Hive 2.x
Date Thu, 19 Mar 2020 20:44:25 GMT
prashantwason commented on a change in pull request #1416: [HUDI-717] Fixed usage of HiveDriver
for DDL statements for Hive 2.x
URL: https://github.com/apache/incubator-hudi/pull/1416#discussion_r395308902
 
 

 ##########
 File path: hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
 ##########
 @@ -198,7 +198,8 @@ private String getPartitionClause(String partition) {
     for (String partition : partitions) {
       String partitionClause = getPartitionClause(partition);
       Path partitionPath = FSUtils.getPartitionPath(syncConfig.basePath, partition);
-      String fullPartitionPath = partitionPath.toUri().getScheme().equals(StorageSchemes.HDFS.getScheme())
+      String partitionScheme = partitionPath.toUri().getScheme();
+      String fullPartitionPath = StorageSchemes.HDFS.getScheme().equals(partitionScheme)
 
 Review comment:
   The original code itself does not seem to support non HDFS sources. Are non HDFS cloud
stores even supported by Hive?
   
   This fix has only changed the order of comparsion as getScheme() may return NULL when there
is no scheme prefix like in the unit-tests. The boolean result of the comparison remains the
same.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message