hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] umehrot2 commented on a change in pull request #1406: [HUDI-713] Fix conversion of Spark array of struct type to Avro schema
Date Wed, 18 Mar 2020 02:15:34 GMT
umehrot2 commented on a change in pull request #1406: [HUDI-713] Fix conversion of Spark array
of struct type to Avro schema
URL: https://github.com/apache/incubator-hudi/pull/1406#discussion_r394069929
 
 

 ##########
 File path: hudi-spark/src/main/scala/org/apache/hudi/AvroConversionHelper.scala
 ##########
 @@ -324,7 +323,7 @@ object AvroConversionHelper {
           avroSchema,
           valueType,
           structName,
-          getNewRecordNamespace(valueType, recordNamespace, structName))
+          recordNamespace)
 
 Review comment:
   Might be good to add a test for Map types as well. We can be sure that we have fixed these
issues once and for all, for all the major types we support. Also in future if spark-avro
changes something we can immediately fix these issues.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message