hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Date Mon, 16 Mar 2020 19:53:01 GMT
satishkotha commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path
to validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r393275453
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
 ##########
 @@ -61,6 +61,7 @@
   private Map<String, HoodieRecord<T>> keyToNewRecords;
   private Set<String> writtenRecordKeys;
   private HoodieStorageWriter<IndexedRecord> storageWriter;
+  private String partitionPath;
 
 Review comment:
   Fixed. I tried to see if there is a way to have this partition validation check in one
place, but couldn't find a common entry point. Please let me know if you have suggestions
here. happy to refactor more if needed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message