hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index
Date Fri, 13 Mar 2020 06:57:49 GMT
vinothchandar commented on a change in pull request #1402: [HUDI-407] Adding Simple Index
URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r392057624
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/index/HoodieIndex.java
 ##########
 @@ -118,9 +121,10 @@ protected HoodieIndex(HoodieWriteConfig config) {
   /**
    * Each index type should implement it's own logic to release any resources acquired during
the process.
    */
-  public void close() {}
+  public void close() {
+  }
 
   public enum IndexType {
-    HBASE, INMEMORY, BLOOM, GLOBAL_BLOOM
+    HBASE, INMEMORY, BLOOM, GLOBAL_BLOOM, SIMPLE
 
 Review comment:
   We should also implement a GLOBAL_SIMPLE? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message