hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader on RO table before a pending compaction
Date Fri, 13 Mar 2020 06:01:07 GMT
vinothchandar commented on a change in pull request #1396: [HUDI-687] Stop incremental reader
on RO table before a pending compaction
URL: https://github.com/apache/incubator-hudi/pull/1396#discussion_r392043054
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTimeline.java
 ##########
 @@ -127,6 +127,24 @@
    */
   HoodieTimeline getCommitsAndCompactionTimeline();
 
+
+  /**
+   * Get all instants (commits, delta commits) that produce new data, in the active timeline.
+   */
+  HoodieTimeline getCommitsTimeline();
+
+  /**
+   * Timeline to include all instants before the first 'requested compaction'.
+   *
+   * For example, say timeline: commit at t0, deltacommit at t1, compaction requested at
t2, deltacommit at t3,
+   * this method would return t0, t1
+   *
+   * If there is no pending compaction this is equivalent to getting all instants in the
timeline.
+   *
+   * @return
+   */
+  HoodieTimeline filterInstantsBeforePendingCompaction();
 
 Review comment:
   Should this belong in the HoodieTimeline class itself? It seems like you can easily build
this using other methods, outside of HoodieTimeline? 
   
   Given this is an interim fix, I would like this to be as isolated as possible from the
core classes.. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message