hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1402: [HUDI-407] Adding Simple Index
Date Fri, 13 Mar 2020 00:32:08 GMT
nsivabalan commented on a change in pull request #1402: [HUDI-407] Adding Simple Index
URL: https://github.com/apache/incubator-hudi/pull/1402#discussion_r391972940
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/TestHoodieClientOnCopyOnWriteStorage.java
 ##########
 @@ -79,9 +82,22 @@
 import static org.mockito.Mockito.when;
 
 @SuppressWarnings("unchecked")
+@RunWith(Parameterized.class)
 public class TestHoodieClientOnCopyOnWriteStorage extends TestHoodieClientBase {
 
   private static final Logger LOG = LogManager.getLogger(TestHoodieClientOnCopyOnWriteStorage.class);
+  private final IndexType indexType;
+
+  @Parameterized.Parameters(name = "{index}: Test with IndexType={0}")
+  public static Collection<Object[]> data() {
+    Object[][] data =
+        new Object[][] {{IndexType.BLOOM},{IndexType.GLOBAL_BLOOM},{IndexType.SIMPLE}};
 
 Review comment:
   @vinothchandar @bvaradar : As part of testing the new simple index, I have parametrized
this test (TestHoodieClientOnCopyOnWriteStorage) and have added other index types as well.
is that fine or do you think the increase in build/test time is not worth it. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message