hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to validate partitionPath
Date Mon, 09 Mar 2020 16:30:10 GMT
bvaradar commented on a change in pull request #1368: [HUDI-650] Modify handleUpdate path to
validate partitionPath
URL: https://github.com/apache/incubator-hudi/pull/1368#discussion_r389807896
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/io/HoodieMergeHandle.java
 ##########
 @@ -61,6 +61,7 @@
   private Map<String, HoodieRecord<T>> keyToNewRecords;
   private Set<String> writtenRecordKeys;
   private HoodieStorageWriter<IndexedRecord> storageWriter;
+  private String partitionPath;
 
 Review comment:
   Now that all handles have partitionPath, can this be moved to base class (HoodieWriteHandle
?) 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message