hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1388: [HUDI-681]Remove embeddedTimelineService from HoodieReadClient
Date Mon, 09 Mar 2020 06:19:37 GMT
vinothchandar commented on a change in pull request #1388: [HUDI-681]Remove embeddedTimelineService
from HoodieReadClient
URL: https://github.com/apache/incubator-hudi/pull/1388#discussion_r389478969
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/client/HoodieReadClient.java
 ##########
 @@ -100,14 +91,6 @@ public HoodieReadClient(JavaSparkContext jsc, String basePath, SQLContext
sqlCon
    * @param clientConfig instance of HoodieWriteConfig
    */
   public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig) {
-    this(jsc, clientConfig, Option.empty());
-  }
-
-  /**
-   * @param clientConfig instance of HoodieWriteConfig
-   */
-  public HoodieReadClient(JavaSparkContext jsc, HoodieWriteConfig clientConfig,
-      Option<EmbeddedTimelineService> timelineService) {
 
 Review comment:
   so this was not doing anything after we changed the class hierrarchy? and this PR is cleaning
this up? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message