hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-hudi] xushiyan commented on a change in pull request #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot Exporter
Date Mon, 09 Mar 2020 03:32:51 GMT
xushiyan commented on a change in pull request #1360: [HUDI-344][RFC-09] Hudi Dataset Snapshot

 File path: hudi-utilities/src/main/java/org/apache/hudi/utilities/
 @@ -0,0 +1,233 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hudi.utilities;
+import com.beust.jcommander.JCommander;
+import com.beust.jcommander.Parameter;
+import org.apache.hadoop.fs.FileStatus;
+import org.apache.hadoop.fs.FileSystem;
+import org.apache.hadoop.fs.FileUtil;
+import org.apache.hadoop.fs.Path;
+import org.apache.hudi.common.util.StringUtils;
+import org.apache.hudi.common.SerializableConfiguration;
+import org.apache.hudi.common.model.HoodiePartitionMetadata;
+import org.apache.hudi.common.table.HoodieTableConfig;
+import org.apache.hudi.common.table.HoodieTableMetaClient;
+import org.apache.hudi.common.table.HoodieTimeline;
+import org.apache.hudi.common.table.TableFileSystemView;
+import org.apache.hudi.common.table.timeline.HoodieInstant;
+import org.apache.hudi.common.table.view.HoodieTableFileSystemView;
+import org.apache.hudi.common.util.FSUtils;
+import org.apache.hudi.common.util.Option;
+import org.apache.log4j.LogManager;
+import org.apache.log4j.Logger;
+import org.apache.spark.sql.Column;
+import org.apache.spark.sql.DataFrameWriter;
+import org.apache.spark.sql.Dataset;
+import org.apache.spark.sql.Row;
+import org.apache.spark.sql.SaveMode;
+import org.apache.spark.sql.SparkSession;
+import org.apache.spark.sql.execution.datasources.DataSource;
+import scala.Tuple2;
+import scala.collection.JavaConversions;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+ * Export the latest records of Hudi dataset to a set of external files (e.g., plain parquet
+ */
+public class HoodieSnapshotExporter {
+  private static final Logger LOG = LogManager.getLogger(HoodieSnapshotExporter.class);
+  public static class Config implements Serializable {
+    @Parameter(names = {"--source-base-path"}, description = "Base path for the source Hudi
dataset to be snapshotted", required = true)
+    String sourceBasePath = null;
+    @Parameter(names = {"--target-base-path"}, description = "Base path for the target output
files (snapshots)", required = true)
+    String targetOutputPath = null;
+    @Parameter(names = {"--snapshot-prefix"}, description = "Snapshot prefix or directory
under the target base path in order to segregate different snapshots")
 Review comment:
   I see there're some gaps...this param `snapshot-prefix` is meant to let users export to
a specific output directory. For example, --target-base-path=/mytable/ --snapshot-prefix=2020/03/03
and the output data will reside in `/mytable/2020/03/03/`. After removing --snapshot-prefix,
the users will simply set --target-base-path=/mytable/2020/03/03/. This is a redundant param
that should be removed from the RFC document too.
   It is not meant to use on --source-base-path. Users will give the right base path to the
hudi dataset to export like --source-base-path=/myhuditable/

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

View raw message