hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] smarthi commented on a change in pull request #1380: [HUDI-668] Added unit-tests for HUDI metrics.
Date Sat, 07 Mar 2020 22:15:20 GMT
smarthi commented on a change in pull request #1380: [HUDI-668] Added unit-tests for HUDI metrics.
URL: https://github.com/apache/incubator-hudi/pull/1380#discussion_r389316113
 
 

 ##########
 File path: hudi-client/src/test/java/org/apache/hudi/metrics/TestHoodieMetrics.java
 ##########
 @@ -18,29 +18,144 @@
 
 package org.apache.hudi.metrics;
 
+import org.apache.hudi.common.model.HoodieCommitMetadata;
 import org.apache.hudi.config.HoodieWriteConfig;
 
 import org.junit.Before;
 import org.junit.Test;
 
+import com.codahale.metrics.Timer;
+
 import static org.apache.hudi.metrics.Metrics.registerGauge;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.when;
 
+import java.util.Arrays;
+import java.util.Random;
+
 
 Review comment:
   Move the static imports after other imports at the end

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message