From commits-return-12090-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Feb 25 07:01:10 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E404D18025F for ; Tue, 25 Feb 2020 08:01:09 +0100 (CET) Received: (qmail 22866 invoked by uid 500); 25 Feb 2020 07:01:09 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 22856 invoked by uid 99); 25 Feb 2020 07:01:09 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2020 07:01:09 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1341: [HUDI-626] Add exportToTable option to CLI Message-ID: <158261406929.16528.7469200182473896386.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 25 Feb 2020 07:01:09 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit satishkotha commented on a change in pull request #1341: [HUDI-626] Add exportToTable option to CLI URL: https://github.com/apache/incubator-hudi/pull/1341#discussion_r383690354 ########## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CommitsCommand.java ########## @@ -145,13 +148,16 @@ private String printCommitsWithMetadata(HoodieDefaultTimeline timeline, .addTableHeaderField("Total Rollback Blocks").addTableHeaderField("Total Log Records") .addTableHeaderField("Total Updated Records Compacted").addTableHeaderField("Total Write Bytes"); - return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending, limit, headerOnly, rows); + return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending, + limit, headerOnly, rows, tempTableName); } @CliCommand(value = "commits show", help = "Show the commits") public String showCommits( @CliOption(key = {"includeExtraMetadata"}, help = "Include extra metadata", unspecifiedDefaultValue = "false") final boolean includeExtraMetadata, + @CliOption(key = {"exportToTableName"}, mandatory = false, help = "hive table name to export", Review comment: Changed names to view instead of table. Initial idea was to create actual tables with all the metadata and register them. so thats where name came from. But, i think exporting to external table requires lot more work with the way CLI is setup. Just doing views in CLI for now. I can work on writing a tool outside CLI to export metadata to another table. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services