From commits-return-12070-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Feb 25 02:57:52 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E4F901802C7 for ; Tue, 25 Feb 2020 03:57:51 +0100 (CET) Received: (qmail 14268 invoked by uid 500); 25 Feb 2020 02:57:51 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 14258 invoked by uid 99); 25 Feb 2020 02:57:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 25 Feb 2020 02:57:51 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client Message-ID: <158259947108.31849.3267781895000805089.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 25 Feb 2020 02:57:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383633637 ########## File path: hudi-client/src/test/java/org/apache/hudi/client/TestHoodieClientBase.java ########## @@ -16,8 +16,10 @@ * limitations under the License. */ -package org.apache.hudi; +package org.apache.hudi.client; +import org.apache.hudi.common.HoodieClientTestHarness; +import org.apache.hudi.WriteStatus; Review comment: Actually, I agree with the context like `SparkContext` can be placed under the top-level package. However, IMO, the `WriteStatus` is not as important as `SparkContext`. It is not been used anywhere. Hudi support `write` and `read` operation. We should make them a pair relationship. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services