From commits-return-12037-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Mon Feb 24 20:00:38 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id F2C881802C7 for ; Mon, 24 Feb 2020 21:00:37 +0100 (CET) Received: (qmail 79442 invoked by uid 500); 24 Feb 2020 20:00:37 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 79433 invoked by uid 99); 24 Feb 2020 20:00:37 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Feb 2020 20:00:37 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1347: [HUDI-627] Aggregate code coverage and publish to codecov.io during CI Message-ID: <158257443725.25018.13337407855048332245.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 24 Feb 2020 20:00:37 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit prashantwason commented on a change in pull request #1347: [HUDI-627] Aggregate code coverage and publish to codecov.io during CI URL: https://github.com/apache/incubator-hudi/pull/1347#discussion_r383483676 ########## File path: pom.xml ########## @@ -278,8 +276,6 @@ report - - ${project.build.directory}/coverage-reports/jacoco-ut.exec Review comment: As per the following link, you can have JaCoCo append coverage of all modules in the same file in the parent module target folder. We can change the dataFile to "${project.basedir}/../target/coverage-reports/jacoco-ut.exec". https://community.sonarsource.com/t/unit-tests-across-multi-module-projects/9662/3 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services