From commits-return-12023-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Mon Feb 24 19:29:51 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id E06CC1802C7 for ; Mon, 24 Feb 2020 20:29:50 +0100 (CET) Received: (qmail 39691 invoked by uid 500); 24 Feb 2020 19:29:50 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 39682 invoked by uid 99); 24 Feb 2020 19:29:50 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Feb 2020 19:29:50 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client Message-ID: <158257259010.15195.16640150885290250230.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 24 Feb 2020 19:29:50 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vinothchandar commented on a change in pull request #1346: [HUDI-554] Cleanup package structure in hudi-client URL: https://github.com/apache/incubator-hudi/pull/1346#discussion_r383467914 ########## File path: hudi-client/src/main/java/org/apache/hudi/table/rollback/RollbackExecutor.java ########## @@ -69,7 +69,7 @@ public RollbackExecutor(HoodieTableMetaClient metaClient, HoodieWriteConfig conf * Performs all rollback actions that we have collected in parallel. */ public List performRollback(JavaSparkContext jsc, HoodieInstant instantToRollback, - List rollbackRequests) { + List rollbackRequests) { Review comment: yes.. will revert. dont know how it got changed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services