From commits-return-11985-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Mon Feb 24 00:33:28 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 26BB6180652 for ; Mon, 24 Feb 2020 01:33:28 +0100 (CET) Received: (qmail 61379 invoked by uid 500); 24 Feb 2020 00:33:27 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 61369 invoked by uid 99); 24 Feb 2020 00:33:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Feb 2020 00:33:27 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions Message-ID: <158250440732.6911.4366609877193447090.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 24 Feb 2020 00:33:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit garyli1019 commented on a change in pull request #1348: HUDI-597 Enable incremental pulling from defined partitions URL: https://github.com/apache/incubator-hudi/pull/1348#discussion_r383055617 ########## File path: hudi-spark/src/main/scala/org/apache/hudi/IncrementalRelation.scala ########## @@ -84,7 +85,7 @@ class IncrementalRelation(val sqlContext: SQLContext, val filters = { if (optParams.contains(DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS_OPT_KEY)) { - val filterStr = optParams.get(DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS_OPT_KEY).getOrElse("") + val filterStr = optParams.getOrElse(DataSourceReadOptions.PUSH_DOWN_INCR_FILTERS_OPT_KEY, "") Review comment: Good point, will do ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services