From commits-return-11624-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Fri Feb 14 23:34:36 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 40468180647 for ; Sat, 15 Feb 2020 00:34:36 +0100 (CET) Received: (qmail 60042 invoked by uid 500); 14 Feb 2020 23:34:35 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 60033 invoked by uid 99); 14 Feb 2020 23:34:35 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 14 Feb 2020 23:34:35 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] ramachandranms commented on a change in pull request #1332: [HUDI -409] Match header and footer block length to improve corrupted block detection Message-ID: <158172327540.13165.6238223440603693413.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 14 Feb 2020 23:34:35 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit ramachandranms commented on a change in pull request #1332: [HUDI -409] Match header and footer block length to improve corrupted block detection URL: https://github.com/apache/incubator-hudi/pull/1332#discussion_r379689535 ########## File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieLogFileReader.java ########## @@ -362,13 +370,18 @@ public HoodieLogBlock prev() throws IOException { // blocksize should read everything about a block including the length as well try { inputStream.seek(reverseLogFilePosition - blockSize); + // get the block size from head and match it with the block size from tail Review comment: talked offline. will create a new JIRA to address reverse reading issues ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services