From commits-return-11244-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Fri Feb 7 02:18:01 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C9E5218064E for ; Fri, 7 Feb 2020 03:18:00 +0100 (CET) Received: (qmail 24957 invoked by uid 500); 7 Feb 2020 02:18:00 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 24948 invoked by uid 99); 7 Feb 2020 02:18:00 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 07 Feb 2020 02:18:00 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance Message-ID: <158104187991.30112.14843480748695831308.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Fri, 07 Feb 2020 02:17:59 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on a change in pull request #1311: [HUDI-602] Add some guidance about how to judge the scope of MINOR to the contribution guidance URL: https://github.com/apache/incubator-hudi/pull/1311#discussion_r376184198 ########## File path: docs/_pages/contributing.cn.md ########## @@ -88,7 +88,11 @@ and more importantly also try to improve the process along the way as well. - Once you finalize on a project/task, please open a new JIRA or assign an existing one to yourself. - Almost all PRs should be linked to a JIRA. It's always good to have a JIRA upfront to avoid duplicating efforts. - - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. + - If the changes are minor, then `[MINOR]` prefix can be added to Pull Request title without a JIRA. There are some tips to help to judge **MINOR** Pull Request : + - trivial fixes (for example, a typo, a broken link or an obvious error) + - the change is not functionality relevant + - changed lines less than 50 Review comment: agree too ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services