From commits-return-11214-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Feb 6 06:21:29 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 014E21806C4 for ; Thu, 6 Feb 2020 07:21:27 +0100 (CET) Received: (qmail 77060 invoked by uid 500); 6 Feb 2020 06:21:27 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 76881 invoked by uid 99); 6 Feb 2020 06:21:27 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Feb 2020 06:21:27 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1151: [WIP] [HUDI-476] Add hudi-examples module Message-ID: <158097008711.17152.14088746865666099368.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 06 Feb 2020 06:21:27 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vinothchandar commented on a change in pull request #1151: [WIP] [HUDI-476] Add hudi-examples module URL: https://github.com/apache/incubator-hudi/pull/1151#discussion_r375657650 ########## File path: pom.xml ########## @@ -408,6 +418,13 @@ ${log4j.version} + Review comment: why is this needed at the parent pom level? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services