From commits-return-11205-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Thu Feb 6 06:21:25 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 72C3318064E for ; Thu, 6 Feb 2020 07:21:25 +0100 (CET) Received: (qmail 76732 invoked by uid 500); 6 Feb 2020 06:21:24 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 76723 invoked by uid 99); 6 Feb 2020 06:21:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 06 Feb 2020 06:21:24 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] hmatu commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive Message-ID: <158097008461.17088.5340762091538438127.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Thu, 06 Feb 2020 06:21:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hmatu commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r375657909 ########## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java ########## @@ -138,9 +139,11 @@ public String showCommits( throws IOException { System.out.println("===============> Showing only " + limit + " archived commits <==============="); - String basePath = HoodieCLI.getTableMetaClient().getBasePath(); + HoodieTableMetaClient metaClient = HoodieCLI.getTableMetaClient(); + String basePath = metaClient.getBasePath(); + Path archivePath = new Path(metaClient.getArchivePath() + "/.commits_.archive*"); FileStatus[] fsStatuses = - FSUtils.getFs(basePath, HoodieCLI.conf).globStatus(new Path(basePath + "/.hoodie/.commits_.archive*")); + FSUtils.getFs(basePath, HoodieCLI.conf).globStatus(archivePath); Review comment: Thanks for your explain, but I still think it's a right way that add `archiveFolderPattern` to `show archived commits command` like `show archived commit stats` dose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services