From commits-return-11170-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Wed Feb 5 21:33:33 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 90C0F18061A for ; Wed, 5 Feb 2020 22:33:33 +0100 (CET) Received: (qmail 30634 invoked by uid 500); 5 Feb 2020 21:33:29 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 30581 invoked by uid 99); 5 Feb 2020 21:33:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2020 21:33:28 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] nbalajee commented on a change in pull request #1307: [HUDI-570] Improve test coverage for FSUtils.java Message-ID: <158093840880.1570.14366561112259680633.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 05 Feb 2020 21:33:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit nbalajee commented on a change in pull request #1307: [HUDI-570] Improve test coverage for FSUtils.java URL: https://github.com/apache/incubator-hudi/pull/1307#discussion_r375520024 ########## File path: hudi-common/src/test/java/org/apache/hudi/common/util/TestFSUtils.java ########## @@ -43,11 +49,33 @@ import java.util.stream.Stream; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertTrue; /** * Tests file system utils. */ public class TestFSUtils extends HoodieCommonTestHarness { + private long minRollbackToKeep = 10; Review comment: incorporated the comments. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services