From commits-return-11167-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Wed Feb 5 20:58:17 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id ACEEA18061A for ; Wed, 5 Feb 2020 21:58:16 +0100 (CET) Received: (qmail 27292 invoked by uid 500); 5 Feb 2020 20:58:16 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 27282 invoked by uid 99); 5 Feb 2020 20:58:16 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 05 Feb 2020 20:58:16 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] vinothchandar commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin Message-ID: <158093629598.30952.2272794061337416439.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Wed, 05 Feb 2020 20:58:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit vinothchandar commented on issue #1290: [HUDI-584] Relocate spark-avro dependency by maven-shade-plugin URL: https://github.com/apache/incubator-hudi/pull/1290#issuecomment-582609037 >If the user wants some changes in spark-avro:3.0-preview2, the right way is modify spark-version to 3.0-preview2 at pom.xml file, then build hudi project source. Understood... but we would like to avoid this need for building a version of hudi by themselves. Users should be able to do `--packages ` and be on their way.. This change forces everyone who is not on the spark version used by hudi to do their own builds.. I still feel this is not a good idea. Once again, I wish we can have more upfront discussion on the JIRA, rather than on a PR, around issues like this. (I feel bad when someone puts in the work to do the implementation that we cannot take :() ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services