From commits-return-11064-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Feb 4 11:53:55 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id C0D6418064E for ; Tue, 4 Feb 2020 12:53:54 +0100 (CET) Received: (qmail 72101 invoked by uid 500); 4 Feb 2020 11:53:54 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 72088 invoked by uid 99); 4 Feb 2020 11:53:54 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2020 11:53:54 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] hmatu commented on issue #1242: [HUDI-544] Adjust the read and write path of archive Message-ID: <158081723409.12643.2834152091968156588.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 04 Feb 2020 11:53:54 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit hmatu commented on issue #1242: [HUDI-544] Adjust the read and write path of archive URL: https://github.com/apache/incubator-hudi/pull/1242#issuecomment-581873000 @hddong @n3nash, `ArchivedCommitsCommand` contains two bellow commands, if just using `metaClient.getArchivePath() + "/.commits_.archive*"`, it will affect old tables. Compare to changes: - `metaClient.getArchivePath() + "/.commits_.archive*"` = '/table/.hoodie/archived/.commits_.archive*' - `basePath + "/.hoodie/.commits_.archive*"` = '/table/.hoodie/.commits_archive*' So the better way is add `archiveFolderPattern` to `show archived commits` command. ``` show archived commit stats ``` ``` show archived commits ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services