From commits-return-11051-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Feb 4 07:49:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id B31A918064E for ; Tue, 4 Feb 2020 08:49:04 +0100 (CET) Received: (qmail 73891 invoked by uid 500); 4 Feb 2020 07:49:04 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 73882 invoked by uid 99); 4 Feb 2020 07:49:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2020 07:49:04 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yanghua commented on issue #1302: [HUDI-595] code cleanup, refactoring code out of PR# 1159 Message-ID: <158080254401.2004.2021890422352648566.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 04 Feb 2020 07:49:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on issue #1302: [HUDI-595] code cleanup, refactoring code out of PR# 1159 URL: https://github.com/apache/incubator-hudi/pull/1302#issuecomment-581783545 > > @smarthi Thanks for your contribution. I left some comments you can consider. > > @yanghua addressed ur comments. @smarthi Thanks, one suggestion: next time, it would be better to make the commits which address the reviewers' suggestions to be single commits. it would be more convenient for rechecking. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services