From commits-return-11020-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Tue Feb 4 01:58:19 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9E662180647 for ; Tue, 4 Feb 2020 02:58:19 +0100 (CET) Received: (qmail 36906 invoked by uid 500); 4 Feb 2020 01:58:19 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 36895 invoked by uid 99); 4 Feb 2020 01:58:18 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 04 Feb 2020 01:58:18 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive Message-ID: <158078149890.26502.13835176998750717855.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 04 Feb 2020 01:58:18 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit n3nash commented on a change in pull request #1242: [HUDI-544] Adjust the read and write path of archive URL: https://github.com/apache/incubator-hudi/pull/1242#discussion_r374439323 ########## File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/ArchivedCommitsCommand.java ########## @@ -63,10 +63,7 @@ public String showArchivedCommits( throws IOException { System.out.println("===============> Showing only " + limit + " archived commits <==============="); String basePath = HoodieCLI.getTableMetaClient().getBasePath(); - Path archivePath = new Path(basePath + "/.hoodie/.commits_.archive*"); - if (folder != null && !folder.isEmpty()) { - archivePath = new Path(basePath + "/.hoodie/" + folder); - } + Path archivePath = new Path(HoodieCLI.getTableMetaClient().getArchivePath() + "/.commits_.archive*"); Review comment: I'm assuming `HoodieCLI.getTableMetaClient().getArchivePath()` returns the path with `.hoodie` ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services