From commits-return-11003-archive-asf-public=cust-asf.ponee.io@hudi.apache.org Mon Feb 3 14:47:18 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 17E35180680 for ; Mon, 3 Feb 2020 15:47:17 +0100 (CET) Received: (qmail 27212 invoked by uid 500); 3 Feb 2020 14:47:17 -0000 Mailing-List: contact commits-help@hudi.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hudi.apache.org Delivered-To: mailing list commits@hudi.apache.org Received: (qmail 27158 invoked by uid 99); 3 Feb 2020 14:47:17 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Feb 2020 14:47:17 +0000 From: GitBox To: commits@hudi.apache.org Subject: [GitHub] [incubator-hudi] yanghua commented on a change in pull request #1302: [HUDI-595] code cleanup, refactoring code out of PR# 1159 Message-ID: <158074123733.19476.9611645966071420281.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Mon, 03 Feb 2020 14:47:17 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit yanghua commented on a change in pull request #1302: [HUDI-595] code cleanup, refactoring code out of PR# 1159 URL: https://github.com/apache/incubator-hudi/pull/1302#discussion_r374137467 ########## File path: hudi-common/src/test/java/org/apache/hudi/common/table/view/TestHoodieTableFileSystemView.java ########## @@ -322,7 +322,7 @@ protected void testViewForFileSlicesWithAsyncCompaction(boolean skipCreatingData assertEquals("Expect only valid data-file", dataFileName, dataFiles.get(0).getFileName()); } - /** Merge API Tests **/ + /* Merge API Tests **/ Review comment: If it's only a single-line comment, we can use `//`. WDYT? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services