hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] amitsingh-10 opened a new pull request #1339: [HUDI-617] Add support for types implementing CharSequence
Date Tue, 18 Feb 2020 10:01:10 GMT
amitsingh-10 opened a new pull request #1339: [HUDI-617] Add support for types implementing
CharSequence
URL: https://github.com/apache/incubator-hudi/pull/1339
 
 
   ## What is the purpose of the pull request
   Data types extending CharSequence implement a #toString method which
   provides an easy way to convert them to String. For example,
   org.apache.avro.util.Utf8 is easily convertible into String if we use
   the toString() method. It's better to make the support more generic to
   support a wider range of data types as partitionKey.
   
   ## Brief change log
     - *Modified TimestampBasedKeyGenerator to support data types convertible to String*
   
   ## Verify this pull request
   
   This pull request is already covered by existing tests, such as *TestTimestampBasedKeyGenerator.java*.
   
   ## Committer checklist
   
   - [x] Has a corresponding JIRA in PR title & commit
    
    - [x] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message