hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] ramachandranms opened a new pull request #1332: [HUDI -409] Match header and footer block length to improve corrupted block detection
Date Thu, 13 Feb 2020 23:13:33 GMT
ramachandranms opened a new pull request #1332: [HUDI -409] Match header and footer block length
to improve corrupted block detection
URL: https://github.com/apache/incubator-hudi/pull/1332
 
 
   ## What is the purpose of the pull request
   
   - This PR is to address the JIRA ticket - [HUDI-409](https://issues.apache.org/jira/browse/HUDI-409)
   - Current logic to determine corrupted block (by just using \#HUDI\# marker alone) fails
to address following issues
     1. Crashing the reader if the next block of the corrupted block has the exact same size
as amount of missing data from the corrupted block
     2. Start of the next block is determined solely based on the marker and this can create
multiple corrupted block if the partial data of corrupted block has the marker as part of
the written data
   
   ## Brief change log
   
   - Made changes to HoodieLogFileReader's `next()` and `prev()` methods. Added additional
check to validate if block sizes stored at start and end of the blocks are the same. Report
block as corrupted if they don't match
   - Modified existing unit tests `TestHoodieLogFormat#testAppendAndReadOnCorruptedLog()`
& `TestHoodieLogFormat#testAppendAndReadOnCorruptedLogInReverse()` to add additional blocks
to validate the reader changes
   
   ## Verify this pull request
   
   This change added tests and can be verified as follows:
   
   - Modified  `TestHoodieLogFormat#testAppendAndReadOnCorruptedLog()` & `TestHoodieLogFormat#testAppendAndReadOnCorruptedLogInReverse()`
tests to account for the change
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella
JIRA.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message