hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] nsivabalan commented on a change in pull request #1165: [HUDI-76] Add CSV Source support for Hudi Delta Streamer
Date Sat, 29 Feb 2020 03:56:49 GMT
nsivabalan commented on a change in pull request #1165: [HUDI-76] Add CSV Source support for
Hudi Delta Streamer
URL: https://github.com/apache/incubator-hudi/pull/1165#discussion_r385997241
 
 

 ##########
 File path: hudi-utilities/src/test/java/org/apache/hudi/utilities/TestHoodieDeltaStreamer.java
 ##########
 @@ -653,7 +659,7 @@ private void prepareParquetDFSSource(boolean useSchemaProvider, boolean
hasTrans
     if (useSchemaProvider) {
       parquetProps.setProperty("hoodie.deltastreamer.schemaprovider.source.schema.file",
dfsBasePath + "/source.avsc");
       if (hasTransformer) {
-        parquetProps.setProperty("hoodie.deltastreamer.schemaprovider.source.schema.file",
dfsBasePath + "/target.avsc");
+        parquetProps.setProperty("hoodie.deltastreamer.schemaprovider.target.schema.file",
dfsBasePath + "/target.avsc");
 
 Review comment:
   did you have to fix any of the test because of this change? If not, I am afraid that our
tests did not catch this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message