hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] bvaradar commented on a change in pull request #1357: [HUDI-636] Fix could not get sources warnings while compiling
Date Tue, 25 Feb 2020 17:06:52 GMT
bvaradar commented on a change in pull request #1357: [HUDI-636] Fix could not get sources
warnings while compiling
URL: https://github.com/apache/incubator-hudi/pull/1357#discussion_r384002451
 
 

 ##########
 File path: packaging/hudi-hadoop-mr-bundle/pom.xml
 ##########
 @@ -48,7 +48,7 @@
               <goal>shade</goal>
             </goals>
             <configuration>
-              <createSourcesJar>true</createSourcesJar>
+              <createSourcesJar>false</createSourcesJar>
 
 Review comment:
   Does this mean sources jar will not be getting generated. Instead, can you enable sources
jar for non-bundle packages like hudi-common, hudi-client, .....  ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message