hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] satishkotha commented on a change in pull request #1341: [HUDI-626] Add exportToTable option to CLI
Date Tue, 25 Feb 2020 07:01:09 GMT
satishkotha commented on a change in pull request #1341: [HUDI-626] Add exportToTable option
to CLI
URL: https://github.com/apache/incubator-hudi/pull/1341#discussion_r383690354
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CommitsCommand.java
 ##########
 @@ -145,13 +148,16 @@ private String printCommitsWithMetadata(HoodieDefaultTimeline timeline,
             .addTableHeaderField("Total Rollback Blocks").addTableHeaderField("Total Log
Records")
             .addTableHeaderField("Total Updated Records Compacted").addTableHeaderField("Total
Write Bytes");
 
-    return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending,
limit, headerOnly, rows);
+    return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending,
+            limit, headerOnly, rows, tempTableName);
   }
 
   @CliCommand(value = "commits show", help = "Show the commits")
   public String showCommits(
       @CliOption(key = {"includeExtraMetadata"}, help = "Include extra metadata",
           unspecifiedDefaultValue = "false") final boolean includeExtraMetadata,
+      @CliOption(key = {"exportToTableName"}, mandatory = false, help = "hive table name
to export",
 
 Review comment:
   Changed names to view instead of table. Initial idea was to create actual tables with all
the metadata and register them. so thats where name came from. But, i think exporting to external
table requires lot more work with the way CLI is setup. Just doing views in CLI for now. I
can work on writing a tool outside CLI to export metadata to another table.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message