hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1341: [HUDI-626] Add exportToTable option to CLI
Date Tue, 25 Feb 2020 00:10:58 GMT
prashantwason commented on a change in pull request #1341: [HUDI-626] Add exportToTable option
to CLI
URL: https://github.com/apache/incubator-hudi/pull/1341#discussion_r383588912
 
 

 ##########
 File path: hudi-cli/src/main/java/org/apache/hudi/cli/commands/CommitsCommand.java
 ##########
 @@ -145,13 +148,16 @@ private String printCommitsWithMetadata(HoodieDefaultTimeline timeline,
             .addTableHeaderField("Total Rollback Blocks").addTableHeaderField("Total Log
Records")
             .addTableHeaderField("Total Updated Records Compacted").addTableHeaderField("Total
Write Bytes");
 
-    return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending,
limit, headerOnly, rows);
+    return HoodiePrintHelper.print(header, new HashMap<>(), sortByField, descending,
+            limit, headerOnly, rows, tempTableName);
   }
 
   @CliCommand(value = "commits show", help = "Show the commits")
   public String showCommits(
       @CliOption(key = {"includeExtraMetadata"}, help = "Include extra metadata",
           unspecifiedDefaultValue = "false") final boolean includeExtraMetadata,
+      @CliOption(key = {"exportToTableName"}, mandatory = false, help = "hive table name
to export",
 
 Review comment:
   This is not a real hive table. So maybe reword this for clarity. Also, export means something
persistent while this is a temporary view. 
   
   Name of in-memory view to cache results.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message