hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] prashantwason commented on a change in pull request #1347: [HUDI-627] Aggregate code coverage and publish to codecov.io during CI
Date Mon, 24 Feb 2020 20:00:37 GMT
prashantwason commented on a change in pull request #1347: [HUDI-627] Aggregate code coverage
and publish to codecov.io during CI
URL: https://github.com/apache/incubator-hudi/pull/1347#discussion_r383483676
 
 

 ##########
 File path: pom.xml
 ##########
 @@ -278,8 +276,6 @@
                 <goal>report</goal>
               </goals>
               <configuration>
-                <!-- Sets the path to the file which contains the execution data. -->
-                <dataFile>${project.build.directory}/coverage-reports/jacoco-ut.exec</dataFile>
 
 Review comment:
   As per the following link, you can have JaCoCo append coverage of all modules in the same
file in the parent module target folder. We can change the dataFile to "${project.basedir}/../target/coverage-reports/jacoco-ut.exec".
   
   https://community.sonarsource.com/t/unit-tests-across-multi-module-projects/9662/3
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message