hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #1330: [HUDI-607] Fix to allow creation/syncing of Hive tables partitioned by Date type columns
Date Mon, 24 Feb 2020 19:39:04 GMT
vinothchandar commented on a change in pull request #1330: [HUDI-607] Fix to allow creation/syncing
of Hive tables partitioned by Date type columns
URL: https://github.com/apache/incubator-hudi/pull/1330#discussion_r383472176
 
 

 ##########
 File path: hudi-spark/src/main/java/org/apache/hudi/DataSourceUtils.java
 ##########
 @@ -77,6 +80,11 @@ public static Object getNestedFieldVal(GenericRecord record, String fieldName,
b
 
       // return, if last part of name
       if (i == parts.length - 1) {
+
+        if (isLogicalTypeDate(valueNode, part)) {
 
 Review comment:
   Hmmm.. just feel that now, this method is doing multiple things and those get tricky over
time.. Simple compromise.. please pull this  conversion code to its own helper method, that
we can invoke from here.. that way, over time, more conversions are just added to that helper.,
while this methods just focusses on getting a nested value .

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message