hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around DiskBasedMap & kryo
Date Mon, 24 Feb 2020 02:19:18 GMT
lamber-ken edited a comment on issue #1351: [WIP] [HUDI-625] Fixing performance issues around
DiskBasedMap & kryo
URL: https://github.com/apache/incubator-hudi/pull/1351#issuecomment-590142768
 
 
   This is a great start. 👍 
   
   IMO, because we already set InstantiatorStrategy, so we needn't register class agian.
   `kryo.setInstantiatorStrategy(new org.objenesis.strategy.StdInstantiatorStrategy());`
   
   From kryo guide[1], we also modify this:
   ```
   kryo.setInstantiatorStrategy(new Kryo.DefaultInstantiatorStrategy(new StdInstantiatorStrategy()));
   ```
   
   So, we do bellow changes will be ok
   
   - Change `Kryo kryo = new KryoBase();` to `Kryo kryo = new Kryo();`
   - `kryo.setInstantiatorStrategy(new Kryo.DefaultInstantiatorStrategy(new StdInstantiatorStrategy()));`
   
   [1] https://github.com/EsotericSoftware/kryo#object-creation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message