hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] leesf commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with an equivalent in NumericUtils.java
Date Sun, 23 Feb 2020 02:17:38 GMT
leesf commented on a change in pull request #1350: [HUDI-629]: Replace Guava's Hashing with
an equivalent in NumericUtils.java
URL: https://github.com/apache/incubator-hudi/pull/1350#discussion_r382957503
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/util/NumericUtils.java
 ##########
 @@ -31,4 +41,28 @@ public static String humanReadableByteCount(double bytes) {
     String pre = "KMGTPE".charAt(exp - 1) + "";
     return String.format("%.1f %sB", bytes / Math.pow(1024, exp), pre);
   }
+
+  public static long getMessageDigestHash(final String algorithmName, final String string)
{
+    MessageDigest md = null;
+    try {
+      md = MessageDigest.getInstance(algorithmName);
+    } catch (NoSuchAlgorithmException e) {
+      LOGGER.error("Invalid Algorithm Specified: {}", algorithmName);
 
 Review comment:
   How about removing the LOGGER and throwing exception here? though Objects.requireNonNull(md)
would also throw exception if md is null.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message