hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1320: [HUDI-571] Add min/max headers on archived files
Date Fri, 14 Feb 2020 17:41:30 GMT
n3nash commented on a change in pull request #1320: [HUDI-571] Add min/max headers on archived
files
URL: https://github.com/apache/incubator-hudi/pull/1320#discussion_r379559545
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieLogBlock.java
 ##########
 @@ -121,7 +121,7 @@ public long getLogBlockLength() {
    * new enums at the end.
    */
   public enum HeaderMetadataType {
-    INSTANT_TIME, TARGET_INSTANT_TIME, SCHEMA, COMMAND_BLOCK_TYPE
+    INSTANT_TIME, TARGET_INSTANT_TIME, SCHEMA, COMMAND_BLOCK_TYPE, MIN_INSTANT_TIME, MAX_INSTANT_TIME
 
 Review comment:
   It's not about them being just generic, think of it this way - we are going to start dumping
MetadataTypes into that one class. Now, different log blocks written in different parts of
the code (archival, actual data, may be indexes, may be consolidated metadata) - we will have
no idea what header type is used where without looking through the entire code base, having
some abstraction here will be very helpful. I agree with your point about ordinals in nested
enums, lets test it out and if this doesn't work, we should find another abstraction. let
me know if that makes sense.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message