hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] n3nash commented on a change in pull request #1320: [HUDI-571] Add min/max headers on archived files
Date Wed, 12 Feb 2020 18:24:45 GMT
n3nash commented on a change in pull request #1320: [HUDI-571] Add min/max headers on archived
files
URL: https://github.com/apache/incubator-hudi/pull/1320#discussion_r378431282
 
 

 ##########
 File path: hudi-common/src/main/java/org/apache/hudi/common/table/log/block/HoodieLogBlock.java
 ##########
 @@ -121,7 +121,7 @@ public long getLogBlockLength() {
    * new enums at the end.
    */
   public enum HeaderMetadataType {
-    INSTANT_TIME, TARGET_INSTANT_TIME, SCHEMA, COMMAND_BLOCK_TYPE
+    INSTANT_TIME, TARGET_INSTANT_TIME, SCHEMA, COMMAND_BLOCK_TYPE, MIN_INSTANT_TIME, MAX_INSTANT_TIME
 
 Review comment:
   How about we don't add the MIN_INSTANT_TIME & MAX_INSTANT_TIME to the HeaderMetadataType
but create an enum like   
   ```
   public enum HeaderMetadataType {
       INSTANT_TIME,
       TARGET_INSTANT_TIME,
       SCHEMA,
       COMMAND_BLOCK_TYPE;
       public enum ArchivedLogHeaderMetadataType {
         MIN_INSTANT_TIME;
        ....
       }
     }
   ```
   It looks like we are just overloading the  `HeaderMetadataType` with information that is
pertaining only to archived files which is going to cause confusions when reading actual data
blocks. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message