hudi-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-hudi] leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter
Date Sun, 09 Feb 2020 13:59:13 GMT
leesf commented on a change in pull request #1106: [HUDI-209] Implement JMX metrics reporter
URL: https://github.com/apache/incubator-hudi/pull/1106#discussion_r376786221
 
 

 ##########
 File path: hudi-client/src/main/java/org/apache/hudi/metrics/JmxMetricsReporter.java
 ##########
 @@ -82,6 +102,106 @@ public void report() {
 
   @Override
   public Closeable getReporter() {
-    return null;
+    return jmxServer.getReporter();
+  }
+
+  @Override
+  public void stop() {
+    if (jmxServer != null) {
+      try {
+        jmxServer.stop();
+      } catch (IOException e) {
+        LOG.error("Failed to stop JMX server.", e);
+      }
+    }
+  }
+
+  /**
+   * JMX Server implementation that JMX clients can connect to.
+   *
+   * <p>Heavily based on j256 simplejmx project
 
 Review comment:
   we would add the license to LICENSE file? @vinothchandar Let's get this on land.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message